RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v4]

[iaroslavski]

On Wed, 11 Oct 2023 20:10:12 GMT, iaroslavski <duke at openjdk.org> wrote:

> > > > > Also @forceinline in these changes only works for case when new intrinsics are not used. I would suggest to adapt/update JMH benchmark to cover all cases and see effect @forceinline without intrinsics. That will tell us which @forceinline annotations are needed.
> > > > 
> > > > 
> > > > Added `@ForceInline` annotations to `insertionSort` and `mixedInsertionSort` as it is helping arrays of small sizes when intrinsics are disabled.
> > > > Thanks, Vamsi
> > > 
> > > @vamsi-parasa Please revert changes (adding @forceinline to insertionSort and mixedInsertionSort) - I checked: initinal version works faster.
> > 
> > @iaroslavski Vladimir, have you used `-XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_arraySort,_arrayPartition` to disable the intrinsics? Also, it helps to have one warmup iteration of 30 secs to reduce run-to-run variance.
> 
> @vamsi-parasa Yes, I tried with the disabled mentioned intrinsics.

@vamsi-parasa, and no profit with @forceinline on insertionSort and mixedInsertionSort.
I suggest removing @forceinline from insertionSort and mixedInsertionSort.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16124#issuecomment-1758516159