RFR: JDK-8318176: C2: dont assert in ~GraphKit if compilation had been interrupted

[Tobias Hartmann]

On Mon, 16 Oct 2023 15:59:10 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> If compilation had been interrupted, which may have happened e.g. due to reaching the node limit check, the using code may not have called `GraphKit::transfer_exceptions_into_jvms()` yet; in that case, we should not assert.

src/hotspot/share/opto/graphKit.hpp line 85:

> 83: #ifdef ASSERT
> 84:   ~GraphKit() {
> 85:     assert(Compile::current()->failing() || !has_exceptions(), "user must call transfer_exceptions_into_jvms");

Couldn't you just call `GraphKit::failing()`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16203#discussion_r1361917967