RFR: JDK-8318176: C2: dont assert in ~GraphKit if compilation had been interrupted

[Thomas Stuefe]

On Tue, 17 Oct 2023 10:54:53 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> If compilation had been interrupted, which may have happened e.g. due to reaching the node limit check, the using code may not have called `GraphKit::transfer_exceptions_into_jvms()` yet; in that case, we should not assert.
>
> src/hotspot/share/opto/graphKit.hpp line 85:
> 
>> 83: #ifdef ASSERT
>> 84:   ~GraphKit() {
>> 85:     assert(Compile::current()->failing() || !has_exceptions(), "user must call transfer_exceptions_into_jvms");
> 
> Couldn't you just call `GraphKit::failing()`?

Possibly. I also realized this can be merged with JDK-8318183 (https://github.com/openjdk/jdk/pull/16205), so I close this PR and fix the graphkit dtor over there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16203#discussion_r1362030018