RFR: 8318455: Make the compiler/ ... /SharedTrampolineTest.java require C2 explicitly

Tobias Hartmann thartmann at openjdk.org
Thu Oct 19 08:00:44 UTC 2023


On Thu, 19 Oct 2023 06:03:36 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> The test seem to only work with C2. A previous change to the test, the JDK-8314838, allowed for passing JVM arguments to the child process. However, if those parameters change the compiler used, the test fails.
> 
> This PR makes this requirement (to have C2 as compiler) explicit.
> 
> Testing: runs with '-XX:TieredStopAtLevel=3' with old version (failed), fixed version (skipped) and with new version but no additional arguments (passed).

You need to remove the test from the problem list (there's also a PR title mismatch). Looking at https://github.com/openjdk/jdk/pull/15609, I thought that the intention was to pass `-XX:-TieredCompilation` to the sub-process, right? Wouldn't that fix the issue as well and doesn't that suggest that https://github.com/openjdk/jdk/pull/15609 does not work as intended?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16258#issuecomment-1770267684


More information about the hotspot-compiler-dev mailing list