RFR: Make the compiler/sharedstubs/SharedTrampolineTest.java require C2 explicitly

Evgeny Nikitin enikitin at openjdk.org
Thu Oct 19 11:14:39 UTC 2023


On Thu, 19 Oct 2023 07:58:29 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> You need to remove the test from the problem list

Fixed, thanks.

> (there's also a PR title mismatch)

Fixed.

> #15609 does not work as intended?

The purpose of the previous PR was to enable forwarding of the additional arguments (like -Xcomp, stress options, whatever) to the child process, this does work now.

> I thought that the intention was to pass -XX:-TieredCompilation to the sub-process, right?

Well, the author intention was, I guess, to disable C1 and always work with C2 and tier 4. This is done now. However, it was possible to override that, AFAIU, by providing additional (even conflicting) TierStopAtLevel's, etc - which is causing the failures.

This PR simply states that the test does require C2 and if user adds some conflicting arguments breaking this assumption, the test would simply be skipped.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16258#issuecomment-1770619618


More information about the hotspot-compiler-dev mailing list