RFR: JDK-8283140: Remove unused encoding classes/operands from x86_64.ad [v2]

Cesar Soares Lucas cslucas at openjdk.org
Wed Oct 25 17:29:36 UTC 2023


On Wed, 25 Oct 2023 07:17:58 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - Update src/hotspot/cpu/x86/x86_64.ad
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/cpu/x86/x86_64.ad
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/cpu/x86/x86_64.ad
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/cpu/x86/x86_64.ad
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/cpu/x86/x86_64.ad
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/cpu/x86/x86_64.ad
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/cpu/x86/x86_64.ad line 818:
> 
>> 816: 
>> 817:   if (framesize) {
>> 818:     __ addq(as_Register(RSP_enc), framesize);
> 
> Isn't this changing the encoding of the add?

Thanks for reviewing @TobiHartmann . Why do you think it changes the encoding?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1372097659


More information about the hotspot-compiler-dev mailing list