RFR: JDK-8283140: Remove unused encoding classes/operands from x86_64.ad [v2]

Thu Oct 26 06:50:32 UTC 2023

On Wed, 25 Oct 2023 17:27:11 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> src/hotspot/cpu/x86/x86_64.ad line 818:
>> 
>>> 816: 
>>> 817:   if (framesize) {
>>> 818:     __ addq(as_Register(RSP_enc), framesize);
>> 
>> Isn't this changing the encoding of the add?
>
> Thanks for reviewing @TobiHartmann . Why do you think it changes the encoding?

Because before your change, the add is encoded with `0x83` if the framesize is small enough and I think `Assembler::addq` always uses the `0x81` encoding, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1372664028