RFR: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint [v10]

Fei Yang fyang at openjdk.org
Mon Sep 4 00:29:43 UTC 2023


On Fri, 1 Sep 2023 07:20:10 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Ilya Gavrilin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in c2_MacroAssembler_riscv.cpp
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1412:
> 
>> 1410:   // tmp2 = 100...0000
>> 1411:   addi(tmp2, zr, 1);
>> 1412:   slli(tmp2, tmp2, 63);
> 
> Better to move these two lines with code comments after `fcvt_l_d(tmp1, src, rm);`

In fact, I mean, move this two lines after `fcvt_l_d(tmp1, src, rm);`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14991#discussion_r1314343375


More information about the hotspot-compiler-dev mailing list