RFR: 8315637: JDK-8314249 broke libgraal
Doug Simon
dnsimon at openjdk.org
Wed Sep 6 07:04:39 UTC 2023
On Tue, 5 Sep 2023 23:20:17 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> Please review this change in JVMCI. The actual functional change is essentially the same as the patch provided by @dougxc in [JDK-8315637](https://bugs.openjdk.org/browse/JDK-8315637) -- convert the `rawIndex` to `cpci` only if the bytecode is INVOKE{VIRTUAL,SPECIAL,STATIC,INTERFACE}.
>
> The rest of the changes is to rename the parameters from `rawIndex` to `which`, so we know the correct type of index is passed. I also added a test case.
>
> (This code should be much simpler after [JDK-8301993](https://bugs.openjdk.org/browse/JDK-8301993) is complete: we won't have `cpci` anymore and all `which` can be replaced with `rawInex`).
Marked as reviewed by dnsimon (Reviewer).
Thanks for the extra cleanup and tests.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15575#pullrequestreview-1612624224
PR Comment: https://git.openjdk.org/jdk/pull/15575#issuecomment-1707782285
More information about the hotspot-compiler-dev
mailing list