RFR: 8314838: 3 compiler tests ignore vm flags [v2]

Evgeny Nikitin enikitin at openjdk.org
Thu Sep 7 18:49:16 UTC 2023


On Thu, 7 Sep 2023 18:22:19 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use vm.simpleArch instead of the os.arch
>
> test/hotspot/jtreg/compiler/sharedstubs/SharedStubToInterpTest.java line 31:
> 
>> 29:  * @library /test/lib
>> 30:  * @requires vm.opt.TieredStopAtLevel == null & vm.opt.TieredCompilation == null
>> 31:  * @requires os.arch=="amd64" | os.arch=="x86_64" | os.arch=="i386" | os.arch=="x86" | os.arch=="aarch64" | os.arch=="riscv64"
> 
> Consider using `vm.simpleArch` in `@requires`:
> 
> @requires vm.simpleArch == "x86" | vm.simpleArch == "x64" | vm.simpleArch == "aarch64" | vm.simpleArch == "riscv64"

Fixed. Thanks Vladimir!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15609#discussion_r1318990176


More information about the hotspot-compiler-dev mailing list