RFR: 8314838: 3 compiler tests ignore vm flags
Vladimir Kozlov
kvn at openjdk.org
Thu Sep 7 18:24:41 UTC 2023
On Thu, 7 Sep 2023 07:41:44 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:
> For the compiler tests in question this PR:
>
> - replaces all calls to `ProcessTools.createJavaProcessBuilder` with another method, the `createTestJvm`, which prepends given arguments with what was passed to the enclosing test. The change therefore...
> - makes sure the external arguments aren't ignored and are used for creating the inner JVM;
> - adds `@requires` guards in some places - where the test explicitly controls the Tiered Compilation, for example.
>
> Testing: a local and a CI run, no failures registered.
test/hotspot/jtreg/compiler/sharedstubs/SharedStubToInterpTest.java line 31:
> 29: * @library /test/lib
> 30: * @requires vm.opt.TieredStopAtLevel == null & vm.opt.TieredCompilation == null
> 31: * @requires os.arch=="amd64" | os.arch=="x86_64" | os.arch=="i386" | os.arch=="x86" | os.arch=="aarch64" | os.arch=="riscv64"
Consider using `vm.simpleArch` in `@requires`:
@requires vm.simpleArch == "x86" | vm.simpleArch == "x64" | vm.simpleArch == "aarch64" | vm.simpleArch == "riscv64"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15609#discussion_r1318972402
More information about the hotspot-compiler-dev
mailing list