RFR: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs

[Tobias Hartmann]

We hit an assert during loop opts because the control input fed into `must_be_not_null` in `LibraryCallKit::inline_native_notify_jvmti_funcs` is wrong. The problem is that control is obtained from the `GraphKit` while it's been updated via the `IdealKit`. I simply moved the `must_be_not_null` out of the if branch and to before `IdealKit` creation, similar to what we do for other intrinsics.

The original reproducer requires JFR and changes to core libraries (see JBS for details) and I was not able to extract a standalone reproducer. I don't think it's worth it because the required core libraries changes will be integrated separately and then the existing test will trigger the issue (with JFR).

Thanks,
Tobias

-------------

Commit messages:
 - 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs

Changes: https://git.openjdk.org/jdk/pull/15713/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15713&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316130
  Stats: 5 lines in 1 file changed: 2 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/15713.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15713/head:pull/15713

PR: https://git.openjdk.org/jdk/pull/15713