RFR: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs

[Roland Westrelin]

On Wed, 13 Sep 2023 11:50:03 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> We hit an assert during loop opts because the control input fed into `must_be_not_null` in `LibraryCallKit::inline_native_notify_jvmti_funcs` is wrong. The problem is that control is obtained from the `GraphKit` while it's been updated via the `IdealKit`. I simply moved the `must_be_not_null` out of the if branch and to before `IdealKit` creation, similar to what we do for other intrinsics.
> 
> The original reproducer requires JFR and changes to core libraries (see JBS for details) and I was not able to extract a standalone reproducer. I don't think it's worth it because the required core libraries changes will be integrated separately and then the existing test will trigger the issue (with JFR).
> 
> Thanks,
> Tobias

Looks good to me.

-------------

Marked as reviewed by roland (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15713#pullrequestreview-1626338327