RFR: 8315604: IGV: dump and visualize node bottom and phase types [v2]

[Roberto Castañeda Lozano]

On Mon, 25 Sep 2023 07:34:03 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Access Compile pointer via IdealGraphPrinter::C
>
> src/hotspot/share/opto/idealGraphPrinter.cpp line 387:
> 
>> 385:       t->dump_on(&bottom_type_stream);
>> 386:       print_prop("bottom_type", buffer);
>> 387:       if (types != nullptr) {
> 
> Could we just use `Compile::current()->types()` here instead of passing it in? We do not seem to use any other types array apart from `Compile::types()`. We are already accessing `Compile::current()` above on line 375.

Thanks for reviewing, Christian! Good catch, turns out `IdealGraphPrinter` holds a pointer to the `Compile` instance (`Compile* IdealGraphPrinter::C`), so I just used that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15881#discussion_r1337165214