RFR: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture [v2]

[Roberto Castañeda Lozano]

On Fri, 29 Sep 2023 11:50:00 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Looks good to me, modulo issues/comments raised by Christian and a few additional minor comments and suggestions.
>> 
>> It seems the IR test framework's annotation-based precondition language is slowly converging towards jtreg's @requires expressions. In the long run, it would be interesting to investigate whether we could simply reuse the jtreg @requires expression support (as suggested in [JDK-8294279](https://bugs.openjdk.org/browse/JDK-8294279)).
>
>> Appreciate the review @robcasloz. I rewrote parts of the documentation and added more tests.
> 
> The new version looks good. Maybe I missed something, but does any of the newly added tests address my suggestion (https://github.com/openjdk/jdk/pull/15938/files#r1338489724) to check that platform preconditions take precedence over VM flags, i.e. VM flags are not even validated if platform preconditions do not hold?

> > > Appreciate the review @robcasloz. I rewrote parts of the documentation and added more tests.
> > 
> > 
> > The new version looks good. Maybe I missed something, but does any of the newly added tests address my suggestion (https://github.com/openjdk/jdk/pull/15938/files#r1338489724) to check that platform preconditions take precedence over VM flags, i.e. VM flags are not even validated if platform preconditions do not hold?
> 
> Thanks for the review. The intention is that the last four tests in `TestPreconditions.java` test precedence through platform-specific VM flags. As an example `testApplyPlatformSVE` will fail with `Could not find VM flag "UseSVE"` if we remove the `applyIfPlatform` precondition on x64.

Right, thanks for the clarification!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15938#issuecomment-1740789624