RFR: 8327111: Replace remaining usage of create_bool_from_template_assertion_predicate() which requires additional OpaqueLoop*Nodes transformation strategies [v2]

Christian Hagedorn chagedorn at openjdk.org
Fri Apr 5 15:52:29 UTC 2024


On Fri, 5 Apr 2024 15:39:43 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove othervm
>
> src/hotspot/share/opto/loopTransform.cpp line 1499:
> 
>> 1497:   Opaque4Node* new_opaque4_node;
>> 1498:   if (new_stride == nullptr) {
>> 1499:     new_opaque4_node = template_assertion_predicate_expression.clone_and_replace_init(new_init, control, this);
> 
> Optional: Maybe you could add a small comment about why the `new_stride` is a `nullptr` in this case?

Thanks for your review! Good idea, added a comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18628#discussion_r1553914415


More information about the hotspot-compiler-dev mailing list