RFR: 8327111: Replace remaining usage of create_bool_from_template_assertion_predicate() which requires additional OpaqueLoop*Nodes transformation strategies [v2]

[Emanuel Peter]

On Fri, 5 Apr 2024 15:46:38 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> src/hotspot/share/opto/loopTransform.cpp line 1499:
>> 
>>> 1497:   Opaque4Node* new_opaque4_node;
>>> 1498:   if (new_stride == nullptr) {
>>> 1499:     new_opaque4_node = template_assertion_predicate_expression.clone_and_replace_init(new_init, control, this);
>> 
>> Optional: Maybe you could add a small comment about why the `new_stride` is a `nullptr` in this case?
>
> Thanks for your review! Good idea, added a comment.

Ah very nice, even an assert!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18628#discussion_r1553916167