RFR: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow

[Matias Saavedra Silva]

On Thu, 11 Apr 2024 01:25:01 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Noted! I haven't been able to replicate the crash yet, but I think it will be worth moving forward with this patch as a matter of correctness.
>
> Note that `noreg` is currently not properly handled / considered in `load_resolved_field_entry`. And it doesn't look nice to me to only check if `tos_state` with `noreg` in this function. That's why I replaced call to `load_resolved_field_entry` with seperate loads in my propsed fix.

I didn't notice your message until just now, but you're right. I would prefer to use `load_resolved_field_entry` when possible but there are places where fields are loaded individually so I think it's fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18477#discussion_r1561766415