RFR: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow

[Fei Yang]

On Thu, 11 Apr 2024 21:25:25 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Note that `noreg` is currently not properly handled / considered in `load_resolved_field_entry`. And it doesn't look nice to me to only check if `tos_state` with `noreg` in this function. That's why I replaced call to `load_resolved_field_entry` with seperate loads in my propsed fix.
>
> I didn't notice your message until just now, but you're right. I would prefer to use `load_resolved_field_entry` when possible but there are places where fields are loaded individually so I think it's fine.

All right. Another place in `TemplateTable::fast_accessfield` which might be worth turning into a `load_resolved_field_entry` call with `noreg` for `tos_state` for consistency [1][2]:

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/templateTable_aarch64.cpp#L3169-L3170
[2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/templateTable_riscv.cpp#L3139-L3140

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18477#discussion_r1561928814