RFR: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow

[Coleen Phillimore]

On Fri, 12 Apr 2024 02:11:55 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> I didn't notice your message until just now, but you're right. I would prefer to use `load_resolved_field_entry` when possible but there are places where fields are loaded individually so I think it's fine.
>
> All right. Another place in `TemplateTable::fast_accessfield` which might be worth turning into a `load_resolved_field_entry` call with `noreg` for `tos_state` for consistency [1][2]:
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/templateTable_aarch64.cpp#L3169-L3170
> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/templateTable_riscv.cpp#L3139-L3140

I think this change should be limited to fixing the membar issue and the push/pop issue and limit refactoring to a new change if more is wanted, but maybe this could call load_resolved_field_entry with noreg for tos-state too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18477#discussion_r1562456477