RFR: 8320725: C2: Add "requires_strict_order" flag for floating-point add-reduction [v5]

[Emanuel Peter]

On Tue, 5 Mar 2024 08:20:24 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

>> src/hotspot/share/opto/vectorIntrinsics.cpp line 1740:
>> 
>>> 1738:   Node* value = nullptr;
>>> 1739:   if (mask == nullptr) {
>>> 1740:     assert(!is_masked_op, "Masked op needs the mask value never null");
>> 
>> This assert may be missed after your refactor. But it seems not really matter.
>
> Yes, the conditions of `mask != nullptr` should take care of that.

It would not hurt to add an assert, see my other suggestion below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1565269700