RFR: 8320725: C2: Add "requires_strict_order" flag for floating-point add-reduction [v5]

Emanuel Peter epeter at openjdk.org
Mon Apr 15 10:56:45 UTC 2024


On Mon, 15 Apr 2024 10:51:40 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/aarch64_vector.ad line 2856:
>> 
>>> 2854: %}
>>> 2855: 
>>> 2856: // reduction addF
>> 
>> Suggestion:
>> 
>> 
>> I think comment could be removed, it seems redundant.
>
> Well, under "Vector reduction add" title, we have sub titles for reductions of various types. For ex. "reduction addI" for integers, "reduction addL" for Longs etc. It might be good to follow this format and also keep "reduction addF" for floats and "reduction addD" for Doubles. What do you think?

I would vote to eventually remove all of them, they really don't add value. But I don't care too much, so feel free to leave them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1565588539


More information about the hotspot-compiler-dev mailing list