RFR: 8320725: C2: Add "requires_strict_order" flag for floating-point add-reduction [v5]
Bhavana Kilambi
bkilambi at openjdk.org
Mon Apr 15 10:56:45 UTC 2024
On Mon, 15 Apr 2024 06:56:48 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert to previous indentation
>
> src/hotspot/cpu/aarch64/aarch64_vector.ad line 2856:
>
>> 2854: %}
>> 2855:
>> 2856: // reduction addF
>
> Suggestion:
>
>
> I think comment could be removed, it seems redundant.
Well, under "Vector reduction add" title, we have sub titles for reductions of various types. For ex. "reduction addI" for integers, "reduction addL" for Longs etc. It might be good to follow this format and also keep "reduction addF" for floats and "reduction addD" for Doubles. What do you think?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1565585973
More information about the hotspot-compiler-dev
mailing list