RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v9]

Andrew Haley aph at openjdk.org
Mon Apr 22 15:53:31 UTC 2024


On Thu, 11 Apr 2024 10:52:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>>> The only issue I have for an exhaustive test for the 32-bit range is that it takes too long time to be an automatic test, and we don't want to add an manual test as it seldomly runs.
>> 
>> But it takes a long time because you use the @Run attribute, surely. If you ran that test just as a test, without the IR framework, it'd be fine.
>
> @theRealAph out of office, so don't have much time to think this through. But maybe we want both, a slower IR test which ensures we have the desired IR (with random input values), and also a non-IR test that is faster and checks the correct results more exhaustively?

Totally. Then, at least for float, you've got it all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1574992865


More information about the hotspot-compiler-dev mailing list