RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v9]

Emanuel Peter epeter at openjdk.org
Thu Apr 11 10:55:42 UTC 2024


On Wed, 10 Apr 2024 20:20:24 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Do you mean add an exhaustive test for the 32-bit range for the vector instrinsic or scalar one?
>> The only issue I have for an exhaustive test for the 32-bit range is that it takes too long time to be an automatic test, and we don't want to add an manual test as it seldomly runs.
>
>> The only issue I have for an exhaustive test for the 32-bit range is that it takes too long time to be an automatic test, and we don't want to add an manual test as it seldomly runs.
> 
> But it takes a long time because you use the @Run attribute, surely. If you ran that test just as a test, without the IR framework, it'd be fine.

@theRealAph out of office, so don't have much time to think this through. But maybe we want both, a slower IR test which ensures we have the desired IR (with random input values), and also a non-IR test that is faster and checks the correct results more exhaustively?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1560819665


More information about the hotspot-compiler-dev mailing list