RFR: 8330844: Add aliases for conditional jumps and additional instruction forms for x86 [v3]
Scott Gibbons
sgibbons at openjdk.org
Tue Apr 23 16:18:42 UTC 2024
On Tue, 23 Apr 2024 16:08:25 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> src/hotspot/cpu/x86/macroAssembler_x86.hpp line 992:
>>
>>> 990: // * No condition for this * void ALWAYSINLINE jecxz(Label& L, bool maybe_short = true) { jcc(Assembler::cxz, L, maybe_short); }
>>> 991:
>>> 992: // Short versions of the above
>>
>> Suggestion:
>>
>> // * No condition for this * void ALWAYSINLINE jcxz(Label& L, bool maybe_short = true) { jcc(Assembler::cxz, L, maybe_short); }
>> // * No condition for this * void ALWAYSINLINE jecxz(Label& L, bool maybe_short = true) { jcc(Assembler::cxz, L, maybe_short); }
>>
>> // Short versions of the above
>
> Everywhere else it is indented, so it would be nice if this kept the style
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18893#discussion_r1576529956
More information about the hotspot-compiler-dev
mailing list