RFR: 8330844: Add aliases for conditional jumps and additional instruction forms for x86 [v3]
Scott Gibbons
sgibbons at openjdk.org
Tue Apr 23 16:18:42 UTC 2024
On Tue, 23 Apr 2024 16:03:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert changes to arrays_equals
>
> src/hotspot/cpu/x86/macroAssembler_x86.hpp line 1024:
>
>> 1022: void ALWAYSINLINE jpo_b(Label& L) { jccb(Assembler::noParity, L); }
>> 1023: // * No condition for this * void ALWAYSINLINE jcxz_b(Label& L) { jccb(Assembler::cxz, L); }
>> 1024: // * No condition for this * void ALWAYSINLINE jecxz_b(Label& L) { jccb(Assembler::cxz, L); }
>
> Suggestion:
>
> // * No condition for this * void ALWAYSINLINE jcxz_b(Label& L) { jccb(Assembler::cxz, L); }
> // * No condition for this * void ALWAYSINLINE jecxz_b(Label& L) { jccb(Assembler::cxz, L); }
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18893#discussion_r1576529780
More information about the hotspot-compiler-dev
mailing list