RFR: 8328998: Encoding support for Intel APX extended general-purpose registers [v4]

[Steve Dohrmann]

On Thu, 25 Apr 2024 22:48:14 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Steve Dohrmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   bug fix in other ::prefix_rex2
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 3620:
> 
>> 3618:   InstructionAttr attributes(AVX_128bit, /* rex_w */ true, /* legacy_mode */ false, /* no_mask_reg */ true, /* uses_vl */ false);
>> 3619:   // swap src/dst to get correct prefix
>> 3620:   int encode = simd_prefix_and_encode(src, xnoreg, as_XMMRegister(dst->encoding()), VEX_SIMD_66, VEX_OPCODE_0F, &attributes, true);
> 
> Here the last argument to simd_prefix_and_encode shouldn't be true as src is not gpr?

Because of the swap of src and dst args in this case, I think src is actually a gpr here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18476#discussion_r1581455716