RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v2]
Christian Hagedorn
chagedorn at openjdk.org
Thu Aug 8 06:40:17 UTC 2024
On Tue, 6 Aug 2024 13:17:06 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> It is currently not possible to write IR tests with `@Stable` annotations because one need to somehow add the IR test classes to the boot classpath. This patch provides support to write such IR tests. I've added a section to the README to provide guidance on how this can be done.
>>
>> This is motivated by https://github.com/openjdk/jdk/pull/19635.
>>
>> I've tested this patch by taking the current patch of https://github.com/openjdk/jdk/pull/19635, dropping the `RestrictStable` flag and modifying the tests to work with the new IR framework feature:
>>
>> TestFramework testFramework = new TestFramework();
>> testFramework
>> .addFlags("-XX:-TieredCompilation",
>> "-XX:+UseParallelGC")
>> .addTestClassesToBootClassPath()
>> .start();
>>
>>
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>
> Review by Aleksey
Sorry for the delay. That is definitely a good idea to add a simple test to check the new feature. I've added such a test with `@Stable` that fails when not adding the test class to the boot classpath and works otherwise.
-------------
PR Review: https://git.openjdk.org/jdk/pull/20477#pullrequestreview-2226971263
More information about the hotspot-compiler-dev
mailing list