RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v2]

Christian Hagedorn chagedorn at openjdk.org
Thu Aug 8 06:40:17 UTC 2024


On Tue, 6 Aug 2024 13:21:15 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review by Aleksey
>
> test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java line 102:
> 
>> 100:         if (testClassesOnBootClassPath) {
>> 101:             // Add test classes themselves to boot classpath to make them privileged.
>> 102:             bootClassPath += ":" + Utils.TEST_CLASSES;
> 
> I think `:` is not portable, and should instead be `File.pathSeparator`?

Good catch! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20477#discussion_r1708739469


More information about the hotspot-compiler-dev mailing list