RFR: 8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build

[Christian Hagedorn]

On Fri, 9 Aug 2024 13:12:14 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>  The testcase `testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java` fails with release build, the test log snippet says `IR verification disabled due to not running a debug build`. So I think it's need `@requires vm.debug == true`.
> 
> The change has been verified with linux x64 release build and linux x64 fastdebug build, no risk,

Changes requested by chagedorn (Reviewer).

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java line 35:

> 33:  * @test
> 34:  * @requires vm.flagless
> 35:  * @requires vm.debug == true

I think the test can also fail when you have a build without C2 compiler. Just to be sure, I would add the following:
Suggestion:

 * @requires vm.debug == true & vm.compMode != "Xint" & vm.compiler2.enabled & vm.flagless

-------------

PR Review: https://git.openjdk.org/jdk/pull/20524#pullrequestreview-2230182000
PR Review Comment: https://git.openjdk.org/jdk/pull/20524#discussion_r1711457625