RFR: 8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build [v2]

SendaoYan syan at openjdk.org
Fri Aug 9 14:20:03 UTC 2024


On Fri, 9 Aug 2024 13:22:56 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   since this test also fails when have a debug build without compilers, so change requires to `* @requires vm.debug == true & vm.compMode != "Xint" & vm.compiler2.enabled & vm.flagless`
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java line 35:
> 
>> 33:  * @test
>> 34:  * @requires vm.flagless
>> 35:  * @requires vm.debug == true
> 
> I think the test can also fail when you have a build without C2 compiler. Just to be sure, I would add the following:
> Suggestion:
> 
>  * @requires vm.debug == true & vm.compMode != "Xint" & vm.compiler2.enabled & vm.flagless

Thanks for your advice. Does `vm.compiler2.enabled & vm.flagless` include the situation `vm.compMode != "Xint"`, I mean `vm.compMode != "Xint"` not needed when set requires `vm.compiler2.enabled & vm.flagless`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20524#discussion_r1711552578


More information about the hotspot-compiler-dev mailing list