RFR: 8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build [v2]

Christian Hagedorn chagedorn at openjdk.org
Fri Aug 9 14:25:31 UTC 2024


On Fri, 9 Aug 2024 14:15:56 GMT, SendaoYan <syan at openjdk.org> wrote:

>> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java line 35:
>> 
>>> 33:  * @test
>>> 34:  * @requires vm.flagless
>>> 35:  * @requires vm.debug == true
>> 
>> I think the test can also fail when you have a build without C2 compiler. Just to be sure, I would add the following:
>> Suggestion:
>> 
>>  * @requires vm.debug == true & vm.compMode != "Xint" & vm.compiler2.enabled & vm.flagless
>
> Thanks for your advice. Does `vm.compiler2.enabled & vm.flagless` include the situation `vm.compMode != "Xint"`, I mean `vm.compMode != "Xint"` not needed when set requires `vm.compiler2.enabled & vm.flagless`

Yes, I guess it's not needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20524#discussion_r1711563721


More information about the hotspot-compiler-dev mailing list