RFR: 8337702: Use new ForwardExceptionNode to call StubRoutines::forward_exception_entry() [v2]

Vladimir Kozlov kvn at openjdk.org
Fri Aug 9 19:56:34 UTC 2024


On Fri, 9 Aug 2024 08:34:59 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix arm (32 bits) build
>
> src/hotspot/cpu/aarch64/aarch64.ad line 16188:
> 
>> 16186: 
>> 16187: // Forward exception.
>> 16188: instruct ForwardExceptionjmp()
> 
> Suggestion:
> 
> instruct ForwardException()
> 
> 
> Same for other AD files.

We can't use the same name for Mach node as for Ideal node:

src/hotspot/cpu/x86/x86_64.ad(12596) Syntax Error: :duplicate name ForwardException for instruction
Error Context:  >>>(<<<)
src/hotspot/cpu/x86/x86_64.ad(12597) Syntax Error: :Identifier expected, but found '%{
  match(ForwardEx[...]'.
Error Context:  >>>%<<<{

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20437#discussion_r1712071962


More information about the hotspot-compiler-dev mailing list