RFR: 8337702: Use new ForwardExceptionNode to call StubRoutines::forward_exception_entry() [v2]
Tobias Hartmann
thartmann at openjdk.org
Mon Aug 12 05:33:32 UTC 2024
On Fri, 9 Aug 2024 19:53:33 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/aarch64.ad line 16188:
>>
>>> 16186:
>>> 16187: // Forward exception.
>>> 16188: instruct ForwardExceptionjmp()
>>
>> Suggestion:
>>
>> instruct ForwardException()
>>
>>
>> Same for other AD files.
>
> We can't use the same name for Mach node as for Ideal node:
>
> src/hotspot/cpu/x86/x86_64.ad(12596) Syntax Error: :duplicate name ForwardException for instruction
> Error Context: >>>(<<<)
> src/hotspot/cpu/x86/x86_64.ad(12597) Syntax Error: :Identifier expected, but found '%{
> match(ForwardEx[...]'.
> Error Context: >>>%<<<{
Ah, makes sense.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20437#discussion_r1713185542
More information about the hotspot-compiler-dev
mailing list