RFR: 8319690: [AArch64] C2 compilation hits offset_ok_for_immed: assert "c2 compiler bug" [v4]

[Fei Gao]

On Fri, 5 Jul 2024 09:19:47 GMT, Andrew Haley <aph at openjdk.org> wrote:

>>> > We can still see the extra register copy. So, I guess it is not caused by this PR and it does exist before?
>>> 
>>> If so then might it be better to relocate Andrew's patch to a separate issue? We may want to backport it independent from this change.
>> 
>> Thanks for your review @adinn . That sounds quite worthwhile. I'm afraid we can't relocate the fix directly, which depends on part of my cleanup in this PR. I'll try to withdraw the common part to make the separate fix simple and clean. Thanks.
>
>> > We can still see the extra register copy. So, I guess it is not caused by this PR and it does exist before?
>> 
>> If so then might it be better to relocate Andrew's patch to a separate issue? We may want to backport it independent from this change.
> 
> And there may be a more powerful way to fix it than my suggestion. I'm thinking of something analgous to `iRegIorL2I` which may be used instead of `regP` as an input to all address-producing patterns.

Hi @theRealAph @adinn @dean-long , can I have a review please? Thanks :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16991#issuecomment-2283393982