Integrated: 8338158: Cleanup ShouldNotXXX uses in machnode.cpp

Kim Barrett kbarrett at openjdk.org
Tue Aug 13 18:06:54 UTC 2024


On Mon, 12 Aug 2024 07:23:57 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to machnode.cpp to remove dead code following calls
> to ShouldNotReachHere() and ShouldNotCallThis().  This takes advantage of the
> availability and use of [[noreturn]] attributes on all supported platforms,
> and makes all uses of those functions in this file consistent in this respect.
> 
> As a side effect, this removes some -Wzero-as-null-pointer-constant warnings.
> 
> Testing: mach5 tier1

This pull request has now been integrated.

Changeset: 8e682aca
Author:    Kim Barrett <kbarrett at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8e682aca24fba0803dceef513957fb2122895b87
Stats:     9 lines in 1 file changed: 0 ins; 4 del; 5 mod

8338158: Cleanup ShouldNotXXX uses in machnode.cpp

Reviewed-by: chagedorn, kvn, dlong

-------------

PR: https://git.openjdk.org/jdk/pull/20540


More information about the hotspot-compiler-dev mailing list