RFR: 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero

Dean Long dlong at openjdk.org
Sat Aug 17 00:14:47 UTC 2024


On Fri, 16 Aug 2024 22:57:35 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> So lowering CompileThreshold to below 117, means "compile sooner", but inline less, because should_not_inline will return true more often?
>
> Yes, the problem is that the tests still expect you to inline things even with small or 0 thresholds. Hence the `1/min_invocations()` floor.

But this turns into should not inline for freq < infinity or freq < 1, or basically "always should not inline".  Wouldn't we want to use MIN2 instead of MAX2 for floor?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20615#discussion_r1720483786


More information about the hotspot-compiler-dev mailing list