RFR: 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero

[Igor Veresov]

On Sat, 17 Aug 2024 00:11:55 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Yes, the problem is that the tests still expect you to inline things even with small or 0 thresholds. Hence the `1/min_invocations()` floor.
>
> But this turns into should not inline for freq < infinity or freq < 1, or basically "always should not inline".  Wouldn't we want to use MIN2 instead of MAX2 for floor?

Good question. I think what I originally meant it to be is the minimum measurable frequency. In that case MAX2 would work. On the other hand, it's not a scaled value. I think we can try removing it and leaving only `freq < MinInlineFrequencyRatio` and see which test fails and why. I, unfortunately, don't remember the details.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20615#discussion_r1720551018