RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v15]

[Emanuel Peter]

On Wed, 20 Nov 2024 11:35:59 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix test
>
> Looks good to me otherwise. Nice tests!

Ok. I'm not sure about the Template vs BasicType. Generally BasicType is what we have used so far, but I would say Templates are cleaner. Discussed it with @TobiHartmann , and he thinks Templates are fine too.

But you need to move the `make_...` to the corresponding file, so others can find it.

And I think the constants in the tests should be given as `1L << 42`, and not some long unreadable chain of digits ;)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22061#issuecomment-2511129198