RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v15]

theoweidmannoracle duke at openjdk.org
Mon Dec 2 16:11:42 UTC 2024


On Mon, 2 Dec 2024 09:55:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/irTests/ModINodeIdealizationTests.java line 43:
>> 
>>> 41: 
>>> 42:     public static void main(String[] args) {
>>> 43:         TestFramework.runWithFlags("-XX:CompileCommand=inline,*Math::max");
>> 
>> Is this really necessary? Should this not happen automatically?
>
> If you do need it: can you add a comment why?

Surprisingly, this does make a difference for long as the intrinsic is currently not used. But since this test is for int, it's not needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22061#discussion_r1866129943


More information about the hotspot-compiler-dev mailing list