RFR: 8345219: C2: x86_64 should not go to interpreter stubs for NaNs handling [v3]

Aleksey Shipilev shade at openjdk.org
Wed Dec 4 14:52:38 UTC 2024


On Tue, 3 Dec 2024 03:10:51 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Disable IR tests on IA32
>
> This fix looks correct by looking on original changes. 
> 
> Yes, special Interpreter's code for these methods is only generated for x86_32 in `templateInterpreterGenerator_x86_32.cpp`.

> I just launched testing, I don't think @vnkozlov did that already. Better to hold off until RDP1 / JDK25 fork anyway.

Thanks! I would like to have this fix in JDK 24, though: it is a (minor) performance optimization, and I would want to know if it breaks anything in ATR before we pull this block out completely when removing x86_32.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22446#issuecomment-2517655873


More information about the hotspot-compiler-dev mailing list