RFR: 8345219: C2: x86_64 should not go to interpreter stubs for NaNs handling [v3]
Emanuel Peter
epeter at openjdk.org
Wed Dec 4 15:11:40 UTC 2024
On Wed, 4 Dec 2024 14:50:11 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> This fix looks correct by looking on original changes.
>>
>> Yes, special Interpreter's code for these methods is only generated for x86_32 in `templateInterpreterGenerator_x86_32.cpp`.
>
>> I just launched testing, I don't think @vnkozlov did that already. Better to hold off until RDP1 / JDK25 fork anyway.
>
> Thanks! I would like to have this fix in JDK 24, though: it is a (minor) performance optimization, and I would want to know if it breaks anything in ATR before we pull this block out completely when removing x86_32.
@shipilev ok, I guess it is a small change and the backout would be simple.
Half of the testing just passed, no failures so far. Give me 1-2h to see if anything comes up.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22446#issuecomment-2517707266
More information about the hotspot-compiler-dev
mailing list