RFR: 8343789: Move mutable nmethod data out of CodeCache [v4]

Boris Ulasevich bulasevich at openjdk.org
Tue Dec 10 22:34:48 UTC 2024


On Fri, 22 Nov 2024 02:54:35 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   extra bool parameter for ldr_patchable
>
> src/hotspot/share/code/nmethod.cpp line 2152:
> 
>> 2150:   delete[] _compiled_ic_data;
>> 2151: 
>> 2152:   if (_immutable_data != blob_end()) {
> 
> Is this just a name change, or a semantic change?

In several places _immutable_data is set to data_end() "valid not null address" address which was actually the end of the code blob. With this change I remove the _data part of the code blob as well as the data_begin() and data_end() functions. I think blob_end() is a good replacement for data_end() for empty _immutable_data cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21276#discussion_r1879006168


More information about the hotspot-compiler-dev mailing list