RFR: 8343789: Move mutable nmethod data out of CodeCache [v4]
Boris Ulasevich
bulasevich at openjdk.org
Tue Dec 10 22:42:42 UTC 2024
On Fri, 22 Nov 2024 02:51:03 GMT, Dean Long <dlong at openjdk.org> wrote:
>> src/hotspot/share/code/codeBlob.cpp line 103:
>>
>>> 101: // The mutable_data_size is either calculated by the nmethod constructor to account
>>> 102: // for reloc_info and additional data, or it is set here to accommodate only the relocation data.
>>> 103: _mutable_data_size = (mutable_data_size == 0) ? cb->total_relocation_size() : mutable_data_size;
>>
>> This seems strange to treat relocations as special. Wouldn't it be better to have the caller always pass in the correct value?
>
> Or compute using something like required_mutable_data_space()?
Alright. Thank you. I moved mutable_data_size calculation out of CodeBlob.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21276#discussion_r1879013357
More information about the hotspot-compiler-dev
mailing list