RFR: 8332827: [REDO] C2: crash in compiled code because of dependency on removed range check CastIIs [v2]

[Roland Westrelin]

On Wed, 11 Dec 2024 07:46:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8332827
>>  - review
>>  - white spaces
>>  - test & fix
>>  - Revert "8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs"
>>    
>>    This reverts commit c9a7b9772d96d9a4825d9da2aacc277534282860.
>
> src/hotspot/share/opto/compile.cpp line 3801:
> 
>> 3799: }
>> 3800: 
>> 3801: void Compile::remove_range_check_cast(CastIINode* cast) {
> 
> Why not make this a member function of `CastIINode`?

Done in new commit.

> test/hotspot/jtreg/compiler/rangechecks/TestArrayAccessAboveRCAfterRCCastIIEliminated.java line 26:
> 
>> 24: /**
>> 25:  * @test
>> 26:  * @bug 8324517
> 
> This bug number does not match the issue.

Fixed in new commit.

> test/hotspot/jtreg/compiler/vectorization/TestVectorizationNegativeScale.java line 30:
> 
>> 28:  *
>> 29:  * @library /test/lib /
>> 30:  * @requires vm.compiler2.enabled
> 
> Is this required? The IR rules are only executed with C2 anyway.

Removed in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22568#discussion_r1880419021
PR Review Comment: https://git.openjdk.org/jdk/pull/22568#discussion_r1880420660
PR Review Comment: https://git.openjdk.org/jdk/pull/22568#discussion_r1880419642