RFR: 8332827: [REDO] C2: crash in compiled code because of dependency on removed range check CastIIs [v2]

[Emanuel Peter]

On Wed, 11 Dec 2024 15:36:51 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The failures that caused the backout were due to a bug in:
>> 
>> `find_or_make_integer_cast()`
>> 
>> which caused the `_range_check_dependency` field's value of the
>> existing cast node to not be set in the new cast node. I re-ran some
>> testing with this fixed and current jdk repo and found that a few
>> vectorization tests fail now because the patch pushes range check
>> `CastII` nodes through `AddI`/`SubI`. To fix this, I delayed that
>> transformation to after loop opts.
>
> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8332827
>  - review
>  - white spaces
>  - test & fix
>  - Revert "8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs"
>    
>    This reverts commit c9a7b9772d96d9a4825d9da2aacc277534282860.

Thanks for the updates, @rwestrel !
The fix looks reasonable. You can add an extra comment for the precedence edges for Div.
I launched some testing now, feel free to ping me later.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22568#issuecomment-2538009216