RFR: 8332827: [REDO] C2: crash in compiled code because of dependency on removed range check CastIIs [v4]

Christian Hagedorn chagedorn at openjdk.org
Thu Dec 19 07:40:43 UTC 2024


On Wed, 18 Dec 2024 16:40:56 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The failures that caused the backout were due to a bug in:
>> 
>> `find_or_make_integer_cast()`
>> 
>> which caused the `_range_check_dependency` field's value of the
>> existing cast node to not be set in the new cast node. I re-ran some
>> testing with this fixed and current jdk repo and found that a few
>> vectorization tests fail now because the patch pushes range check
>> `CastII` nodes through `AddI`/`SubI`. To fix this, I delayed that
>> transformation to after loop opts.
>
> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review

Thanks for the update, looks good!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22568#pullrequestreview-2513564310


More information about the hotspot-compiler-dev mailing list