RFR: 8324679: Replace NULL with nullptr in HotSpot .ad files
Andrew Haley
aph at openjdk.org
Thu Feb 1 10:15:01 UTC 2024
On Wed, 31 Jan 2024 20:18:46 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Thanks for looking at this Vladimir. I made these changes. I don't know about this aarch64_ad.m4. It didn't have any NULL in it so not sure how it would be used to generate aarch64.ad. We can wait for Andrew to answer.
It's done manually. Just `m4 aarch64_ad.m4` then paste the result between
// BEGIN This section of the file is automatically generated. Do not edit --------------
// This section is generated from aarch64_ad.m4
and
`// END This section of the file is automatically generated. Do not edit --------------
`
Yea, that's a bit clunky, but it's a helluva lot more maintainable (and reliable!) than copy-and-pasting all of that boilerplate by hand.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17658#issuecomment-1920969778
More information about the hotspot-compiler-dev
mailing list