RFR: 8324679: Replace NULL with nullptr in HotSpot .ad files

[Coleen Phillimore]

On Thu, 1 Feb 2024 10:12:07 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Thanks for looking at this Vladimir. I made these changes.  I don't know about this aarch64_ad.m4.  It didn't have any NULL in it so not sure how it would be used to generate aarch64.ad.  We can wait for Andrew to answer.
>> 
>> For any other suggested changes, you can use a button like "suggest change" and I'll just click on it.
>
>> Thanks for looking at this Vladimir. I made these changes. I don't know about this aarch64_ad.m4. It didn't have any NULL in it so not sure how it would be used to generate aarch64.ad. We can wait for Andrew to answer.
> 
> It's done manually. Just `m4 aarch64_ad.m4` then paste the result between 
> 
> 
> // BEGIN This section of the file is automatically generated. Do not edit --------------
> // This section is generated from aarch64_ad.m4
> 
> 
> and
> 
> `// END This section of the file is automatically generated. Do not edit --------------
> `
> 
> Yea, that's a bit clunky, but it's a helluva lot more maintainable (and reliable!) than copy-and-pasting all of that boilerplate by hand.

Ok, I see in the .ad file.  There are two sections contained within these BEGIN/END This section pairs.  The sections didn't contain NULL since there wasn't any in the m4 file. So I didn't edit anything in these sections.  Thanks @theRealAph

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17658#issuecomment-1921693825